2 Commits

Author	SHA1	Message	Date
yinwm	ab20314882	Merge upstream/main into ralph/tool-result-refactor ... Resolved conflicts: - pkg/heartbeat/service.go: merged both 'started' field and 'onHeartbeatWithTools' - pkg/tools/edit.go: use validatePath() with ToolResult return - pkg/tools/filesystem.go: fixed return values to use ToolResult - cmd/picoclaw/main.go: kept active setupCronTool, fixed toolsPkg import - pkg/tools/cron.go: fixed Execute return value handling Fixed tests for new function signatures (NewEditFileTool, NewAppendFileTool, NewExecTool) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-13 01:00:26 +08:00
yinwm	35fa64cde8	feat: US-015 - Add EditTool tests ... Added comprehensive test coverage for EditTool (EditFileTool, AppendFileTool) with 10 test cases: - TestEditTool_EditFile_Success: Verifies successful file editing - TestEditTool_EditFile_NotFound: Verifies error handling for non-existent files - TestEditTool_EditFile_OldTextNotFound: Verifies error when old_text not found - TestEditTool_EditFile_MultipleMatches: Verifies error for multiple occurrences - TestEditTool_EditFile_OutsideAllowedDir: Verifies directory restriction - TestEditTool_EditFile_MissingPath: Verifies missing path parameter - TestEditTool_EditFile_MissingOldText: Verifies missing old_text parameter - TestEditTool_EditFile_MissingNewText: Verifies missing new_text parameter - TestEditTool_AppendFile_Success: Verifies successful file appending - TestEditTool_AppendFile_MissingPath: Verifies missing path for append - TestEditTool_AppendFile_MissingContent: Verifies missing content for append EditTool implementation already conforms to ToolResult specification: - EditFile returns SilentResult('File edited: ...') - AppendFile returns SilentResult('Appended to ...') - Errors return ErrorResult with IsError=true EditFileTool includes security feature: optional directory restriction to prevent editing files outside allowed paths. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>	2026-02-12 19:55:57 +08:00